Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD Setup #141

Merged
merged 1 commit into from
May 15, 2019
Merged

CI/CD Setup #141

merged 1 commit into from
May 15, 2019

Conversation

kiraarghy
Copy link
Contributor

  1. Added prettier + script.
  2. Added EsLint + base formidable config + script.
  3. Fixed eslint errors.
  4. Added sail ci config.

@kiraarghy kiraarghy requested review from kitten and sofiapoh May 13, 2019 15:42
sofiapoh
sofiapoh reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@sofiapoh sofiapoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering if there's a way to get around adding // eslint-disable-next-line import/no-unresolved everywhere? It just doesn't seem to understand non-default imports that well and just makes imports look ugly for completely valid code :(

sofiapoh
sofiapoh reviewed May 14, 2019
View reviewed changes
src/components/Editor/index.js Outdated
@@ -55,7 +58,7 @@ class CodeEditor extends Component {
);

render() {
const { style, code: _code, onChange, language, ...rest } = this.props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these will actually cause problems as the ...rest causes those props to leak to the underlying Editor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh okay!

@kiraarghy
CI/CD Setup
49816e6 
1. Added prettier + script.
1. Added EsLint + base formidable config + script.
1. added .eslintignore
1. Fixed eslint errors.
1. Added sail ci config.
@sofiapoh sofiapoh merged commit 05e0ad7 into master May 15, 2019
@sofiapoh sofiapoh deleted the CI/CDSetup branch May 15, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofiapoh sofiapoh sofiapoh left review comments

@kitten kitten Awaiting requested review from kitten

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiraarghy @sofiapoh